add more tests

jump-dev · Dec 11, 2023 · b8d5df4 · b8d5df4
1 parent e68d603
commit b8d5df4
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/diff.jl b/src/diff.jl
@@ -314,14 +314,16 @@ function _quadratic_constraint_get_reverse!(
             p_2 = p_idx(term.variable_2)
             value_1 = get!(model.parameter_output_backward, p_1, 0.0)
             value_2 = get!(model.parameter_output_backward, p_2, 0.0)
+            # TODO: why there is no factor of 2 here????
+            # ANS: probably because it was SET
             model.parameter_output_backward[p_1] =
                 value_1 +
                 term.coefficient * grad_pf_cte * model.parameters[p_2] /
-                ifelse(term.variable_1 === term.variable_2, 2, 1)
+                ifelse(term.variable_1 === term.variable_2, 1, 1)
             model.parameter_output_backward[p_2] =
                 value_2 +
                 term.coefficient * grad_pf_cte * model.parameters[p_1] /
-                ifelse(term.variable_1 === term.variable_2, 2, 1)
+                ifelse(term.variable_1 === term.variable_2, 1, 1)
         end
         for term in pf.pv
             p = p_idx(term.variable_1)
@@ -479,3 +481,5 @@ function MOI.get(
     JuMP.check_belongs_to_model(var_ref, model)
     return _moi_get_result(JuMP.backend(model), attr, JuMP.index(var_ref))
 end
+
+# TODO: ignore ops that are 0
diff --git a/test/jump_diff_param.jl b/test/jump_diff_param.jl
@@ -220,6 +220,31 @@ function test_quadratic_rhs_changes()
                 atol = 1e-10,
             )
         end
+        for dir_x = 0:3
+            MOI.set(model, DiffOpt.ReverseVariablePrimal(), x, dir_x)
+            DiffOpt.reverse_differentiate!(model)
+            @test isapprox(MOI.get(model, POI.ReverseParameter(), p),
+                dir_x * 3 * q_val / (11 * t_val),
+                atol = 1e-10,
+            )
+            @test isapprox(MOI.get(model, POI.ReverseParameter(), q),
+                dir_x * 3 * p_val / (11 * t_val),
+                atol = 1e-10,
+            )
+            @test isapprox(MOI.get(model, POI.ReverseParameter(), r),
+                dir_x * 10 * r_val / (11 * t_val),
+                atol = 1e-10,
+            )
+            @test isapprox(MOI.get(model, POI.ReverseParameter(), s),
+                dir_x * 7 / (11 * t_val),
+                atol = 1e-10,
+            )
+            @test isapprox(MOI.get(model, POI.ReverseParameter(), t),
+                dir_x * (- (1 + 3 * p_val * q_val + 5 * r_val ^ 2 + 7 * s_val) /
+                    (11 * t_val ^ 2)),
+                atol = 1e-10,
+            )
+        end
     end
     return
 end