Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bridges] add VariablePrimalStart support to ParameterToEqualTo and RSOCtoPSD #2337

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

odow
Copy link
Member

@odow odow commented Nov 2, 2023

Part of #684

@odow odow requested a review from blegat November 2, 2023 03:08
@blegat
Copy link
Member

blegat commented Nov 2, 2023

The first two indices are multiplied by a 2x2 matrix (rotation by 90°) which makes this tricky since the starting value for one depend on the one for the other one. For get, it's not too bad, you can just query both. For set, it's a bit more tricky because when you get set the first one, you need to cache it it the bridge and way for the other one. Once you have both, you can set it to the model. We could throw an error in final_touch if we get set only one of them I misread, I thought it was SOC-RSOC bridge

@odow odow merged commit 6d9dd75 into master Nov 2, 2023
15 of 16 checks passed
@odow odow deleted the od/bridge-variable-primal-start branch November 2, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants