Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy_to with unsupported variable and constraint attributes #2333

Closed
wants to merge 2 commits into from

Conversation

odow
Copy link
Member

@odow odow commented Oct 31, 2023

Closes #2327

@blegat
Copy link
Member

blegat commented Oct 31, 2023

I think it was intentional that we only allow skipping if supports is false because it means the solver does not support it. That allows writing a code that sets starting values and then use it with both Mosek and COSMO.
If there is an error since it would mean that something might have gone wrong and the user should know about it, especially since, last time I checked, if you provide an incomplete dual, SCS will just ignore it so if the user has set all the starting values is pretty confusing.
In the case of the issue you are mentioning, I think it's best to error than to just let the solver ignore all starting values and let the user figure out the hard way that one of its starting values was just ignored. We should at least warn.

@odow
Copy link
Member Author

odow commented Oct 31, 2023

That's a reasonable argument. I'm okay to close this PR (and the issue) then. We can always wait to see if we get complaints, not that the error message is better.

@odow odow closed this Oct 31, 2023
@odow odow deleted the od/fix-copy-unsupported branch October 31, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Starting value in unsupported bridge errors instead of skipping
2 participants