[Test] improve test_attribute_TimeLimitSec #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbesancon
approved these changes
Aug 14, 2023
|
Ah. I think I know why I did it like this originally. The default for "unset" time limits was never standardized across solvers. |
blegat
approved these changes
Aug 16, 2023
|
This breaks a bunch of solver tests, so I'll hold off merging for now. |
This was referenced Aug 17, 2023
odow
force-pushed
the
od/time-limit-sec
branch
from
d23ef61 to
2264bca
Compare
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref jump-dev/SCS.jl#280
SCS was throwing
GetAttributeNotAllowed, so this test was being skipped.