-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bump version number, update CRAN comments
- Loading branch information
1 parent
02b478d
commit 5c40e69
Showing
2 changed files
with
6 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| Package: janeaustenr | ||
| Title: Jane Austen's Complete Novels | ||
| Version: 0.1.0.9000 | ||
| Version: 0.1.1 | ||
| Date: 2016-06-20 | ||
| Authors@R: person("Julia", "Silge", email = "[email protected]", role = c("aut", "cre")) | ||
| Description: Full texts for Jane Austen's 6 completed novels, ready for text | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,18 @@ | ||
| ## Resubmission | ||
|
|
||
| This is a resubmission. In this version I have: | ||
|
|
||
| * Changed http to https for CRAN in README | ||
|
|
||
| ## Release summary | ||
|
|
||
| This is the first attempted CRAN release of janeaustenr, and my first submission to CRAN. | ||
| This is the second CRAN release of janeaustenr. I am submitting a new release to solve a problem of a formatting change in the previous release's .rda files at 10000 lines. | ||
|
|
||
| ## Test environments | ||
|
|
||
| * Local OS X install: R 3.2.4, R-devel | ||
| * Ubuntu 14.04 (on Travis-CI): R 3.2.4, R-devel | ||
| * Local OS X install: R 3.3.0 | ||
| * Ubuntu 14.04 (on Travis-CI): R 3.3.0 | ||
| * Win-builder: R-devel and R-release | ||
|
|
||
| ## R CMD check results | ||
|
|
||
| 0 errors | 0 warnings | 2 notes | ||
|
|
||
| There is 1 note about me being a new maintainer. | ||
|
|
||
| There is 1 note about non-ASCII, marked UTF-8 strings; there are 2 in the data sets. | ||
|
|
||
| * `mansfieldpark[14652]` has a British pound symbol. | ||
| * `persuasion[7066]` has an e with an accent grave (in the word "arrangè") | ||
|
|
||
| I believe it would be inappropriate to change these as these are the published texts, so I would like to keep them as is. | ||
| 0 errors | 0 warnings | 0 notes | ||
|
|
||
| Also, there was a message about possibly invalid URLs for the Project Gutenberg URLs in the .Rd files, and about possibly mis-spelled words in DESCRIPTION ("Austen's" at 2:30 and 6:34, "Northanger" at 8:32). | ||
| There was a message about possibly invalid URLs for the Project Gutenberg URLs in the .Rd files, and about possibly mis-spelled words in DESCRIPTION ("Austen's" at 2:13 and 6:34, "Northanger" at 8:32). | ||
|
|
||
| * Project Gutenberg blocks automated traffic, which caused the issue with the possibly invalid URLs. | ||
| * Those words are spelled correctly. |