Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something we will use @userlike, not sure if you would be interested in this which is a non-breaking change. If so, we can work on merging this.
It introduces
const createResizeObserver: (global: Window) => ResizeObserverCls
and does some changes on the scheduler so that it is less "global". There are other minor changes such asResizeObserverCls
as an interface.Our use case for this is observing changes inside an iframe.
I'm already aware that you have plans to introduce "observed root list" to have better shadow dom support. But until then, perhaps this is not a bad solution because this:
createResizeObserver(global: Window): ResizeObserverCls
API surface is easily maintainable long-term.(Sorry for formatting, prettier user here. Turn "whitespace changes" off. Can undo formatting if we agree on merging this).
Also, you can test it with
@anilanar/resize-observer
if you wish, which is published on npm.