webui: open link in new window

[derCiamas]

Hi! Not a C++ developer but nevertheless hopefully can do my small part;)

I have fixed the Github link to open in new tab as it was not rendering in an IFrame.

[OlMi1]

That's exactly what I did manually. Not sure why this is not pulled yet.

[jtgrassie]

That's exactly what I did manually. Not sure why this is not pulled yet.

Because it's a personal preference to open in a new window or not, surely?

[OlMi1]

That's exactly what I did manually. Not sure why this is not pulled yet.

Because it's a personal preference to open in a new window or not, surely?

Let's say we want to see our hashrate on the site but also wanted to see where the link lead to. Opening it in the same tab disrupts the website flow by redirecting the user to another page and making them leave the first one, shifting focus and annoying the user.

[jtgrassie]

As I said, personal preference. When I want to open a link in a new window, I ctrl-click (or whatever my browser option is). Popping new widows all the time is bad, IMHO.

[derCiamas]

Well actually the link wasn't working at all due to framing policy. This was the reason why I changed it.

[OlMi1]

As I said, personal preference. When I want to open a link in a new window, I ctrl-click (or whatever my browser option is). Popping new widows all the time is bad, IMHO.

Yes, I totally agree. But:
Always open links in the same tab unless doing so 1) could disrupt a process, 2) could risk data loss, or 3) could confuse the user.
(Source)
In our case, condition 1 and 3 are met.

Now, this drifts away from the original topic of the pull request. Both sides have legitimate arguments. I personally think it would be best to accept the pull request since it would meet Standart web design "laws", but in the end it's up to you.

[OlMi1]

Well actually the link wasn't working at all due to framing policy. This was the reason why I changed it.

...which would make an accept necessary because that would be a bug / programming flaw (even though HTML isn't a programming language, I know)

[jtgrassie]

In our case, condition 1 and 3 are met.

It doesn't interrupt a process (1) and point (3) is subjective. In any case, the embedded html is only present to serve as an example.

Well actually the link wasn't working at all due to framing policy.

So change your framing policy.

[jtgrassie]

which would make an accept necessary because that would be a bug / programming flaw

It is NOT a bug.

[derCiamas]

In our case, condition 1 and 3 are met.

It doesn't interrupt a process (1) and point (3) is subjective. In any case, the embedded html is only present to serve as an example.

Well actually the link wasn't working at all due to framing policy.

So change your framing policy.

Github's framing policy?

[jtgrassie]

So change your framing policy.

Github's framing policy?

Ahhha, OK, if you could update the commit message to something more appropriate like "webui: open link in new window" I'll merge. Thanks

[derCiamas]

@jtgrassie have updated, sorry was away for a couple of days.

[jtgrassie]

@derCiamas can you update the commit message please.