Allow video keyboard plugin to record several responses and save video timestamp

[marianylund]

Hello, this is my first time contributing to an open-source project, so I will highly appreciate any feedback!

Currently the jsPsych video-keyboard-response plugin records only one response and saves response time information and which key was pressed. I need to be able to play a video and record several inputs while user is watching the video and map it to the video to know when in the video user responded.

Now, I´ve added a new boolean multiple_responses_allowed to control if only one response or multiple will be recorded. Also added video_time to the data that is returned.

TODOs:

• Update /docs
• Update example file
• Add changeset
• Update contributors.md

Should I make an issue for this?

[changeset-bot]

⚠️ No Changeset found

Latest commit: fd753de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[jodeleeuw]

Hi @marianylund!

First, thanks for taking the leap to contribute!

I think the kind of change you are proposing would be super useful to folks. However, it might be better to create a new modified plugin instead of changing the main plugin, at least for now. My thinking is that there are several -keyboard-response plugins that all behave in the same basic way, and changing one of them without changing the others would add confusion.

Instead, how about copying the plugin, making modifications, and submitting it to the jspsych/jspsych-contrib repository. In the future we could merge it into the main repo if we have similar kinds of modifications to the other keyboard response plugins.

[marianylund]

Thank you @jodeleeuw for your quick response! I have now added a pull request to jspsych-contrib, so I will close this one.