Fix for #80 #81
Open
Fix for #80 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 9, 2017
| @@ -49,6 +51,8 @@ def attribute(name, options = {}, &block) | |||
| _register_condition(field_condition_blocks, name, options) | |||
| end | |||
|
|
|||
|
|
|||
|
|
|||
| @@ -49,6 +51,8 @@ def attribute(name, options = {}, &block) | |||
| _register_condition(field_condition_blocks, name, options) | |||
| end | |||
|
|
|||
|
|
|||
| class << self | ||
| attr_accessor :field_condition_blocks | ||
| attr_accessor :link_condition_blocks | ||
| end | ||
| self.field_condition_blocks ||= {} | ||
| self.link_condition_blocks ||= {} | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at block body end.
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 12 12
Lines 379 379
=======================================
Hits 377 377
Misses 2 2
Continue to review full report at Codecov.
|
beauby
changed the title
|
Hi @daniel-sullivan – thanks for this PR! I'm currently on the road but will take a closer look asap 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for conditional attribute inclusion using the 0.2.1 conditional_fields.rb