Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_kinova_robot] Update README for noetic #1906

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[jsk_kinova_robot] Update README for noetic #1906

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a310b4e
[jsk_kinova_robot] Update README for noetic
Kanazawanaoaki Feb 4, 2024
6ad34b5
[jsk_kinova_robot] Add noetic rosinstall for collad_urdf problem
Kanazawanaoaki Feb 5, 2024
6193b0f
Add setup.bash to use noetic
Kanazawanaoaki Feb 5, 2024
6022d95
Fix ros_distro rosinstall url
Kanazawanaoaki Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jsk_kinova_robot/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ You need to install `conan` (Decentralized, open-source (MIT), C/C++ package man

```bash
sudo apt install python3 python3-pip
python3 -m pip install --user conan
python3 -m pip install --user 'conan<2'
conan config set general.revisions_enabled=1
conan profile new default --detect > /dev/null
conan profile update settings.compiler.libcxx=libstdc++11 default
Expand All @@ -69,9 +69,10 @@ mkdir -p ~/kinova_ws/src
cd ~/kinova_ws/src
wstool init
wstool merge https://raw.githubusercontent.com/jsk-ros-pkg/jsk_robot/master/jsk_kinova_robot/kinova.rosinstall
wstool merge https://raw.githubusercontent.com/Kanazawanaoaki/jsk_robot/kinova-noetic/jsk_kinova_robot/kinova.rosinstall.${ROS_DISTRO} # Please ignore error if kinova.rosinstall.${ROS_DISTRO} does not exist. # We can remove this line after the https://github.com/ros/collada_urdf/pull/44 is merged
Copy link
Member

@mqcmd196 mqcmd196 Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is okay with like
https://raw.githubusercontent.com/jsk-ros-pkg/jsk_robot/master/jsk_kinova_robot/kinova.rosinstall.${ROS_DISTRO}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it. 6022d95

wstool update
cd ../
source /opt/ros/melodic/setup.bash
source /opt/ros/${ROS_DISTRO}/setup.bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NITS: The environment variable ${ROS_DISTRO} has not been set unless the user source /opt/ros/.../setup.bash . So you had better writing like /opt/ros/noetic/setup.bash # If noetic

Copy link
Contributor Author

@Kanazawanaoaki Kanazawanaoaki Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put source /opt/ros/*/setup.bash first because .rosinstall part also uses ${ROS_DISTRO}. 6193b0f

rosdep install -y -r --from-paths src --ignore-src
catkin build jsk_kinova_startup kinovaeus
source devel/setup.bash
Expand Down
12 changes: 12 additions & 0 deletions jsk_kinova_robot/kinova.rosinstall.noetic
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Current collada_urdf cannot be built on noetic # We can remove this line after the https://github.com/ros/collada_urdf/pull/44 is merged
# https://github.com/ros/collada_urdf/pull/44
- git:
local-name: collada_urdf
uri: https://github.com/werner291/collada_urdf.git
version: patch-1
# jsk_model_tools has to be built with patched collada_urdf # We can remove this line after the https://github.com/ros/collada_urdf/pull/44 is merged
# https://github.com/jsk-ros-pkg/jsk_model_tools/pull/254
- git:
local-name: jsk-ros-pkg/jsk_model_tools
uri: https://github.com/Takuma-Hiraoka/jsk_model_tools.git
version: fix_for_python3-python2_compatible
Loading