[pr2-interface.l] check :check-continuous-joint-move-over-180 when simulator mode #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2020
k-okada
force-pushed
the
fix-angle-vector-sequence
branch
from
3aaa008
to
2489966
Compare
k-okada
reviewed
Oct 25, 2022
Comment on lines
-424
to
+425
| (unless (or (send self :simulation-modep) (cadr (memq :end-coords-interpolation args))) | ||
| (let* ((prev-av (send robot :angle-vector (send self :state :reference-vector))) | ||
| (unless (cadr (memq :end-coords-interpolation args)) | ||
| (let* ((prev-av (send robot :angle-vector (if (send self :simulation-modep) (send self :state :potentio-vector) (send self :state :reference-vector)))) |
There was a problem hiding this comment.
This did not existing tests
may be
(unless (or (send self :simulation-modep) (cadr (memq :end-coords-interpolation args)))
(let* ((prev-av (send robot :angle-vector (if (send self :simulation-modep) (send self :state :potentio-vector) (send self :state :reference-vector))))
??? please pass tests @Naoki-Hiraoka
https://github.com/jsk-ros-pkg/jsk_pr2eus/actions/runs/3317672989/jobs/5480786114
+ catkin_test_results --verbose --all build
Full test results for 'pr2eus_moveit/test_results/pr2eus_moveit/rosunit-test_pr2eus_moveit_sim.xml'
-------------------------------------------------
<testsuite tests="2" failures="1" disabled="0" errors="0" time="0" name="AllTests">
<testcase name="all-test" status="run" time="0" classname="all-test">
<failure message="number expected" type="AssertionError">
Test:(/ (elt tms l) div)
Trace:32
Message:"number expected"
</failure>
</testcase>
<testcase name="test-angle-vector-motion-plan" status="run" time="0" classname="test-angle-vector-motion-plan">
</testcase>
</testsuite>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #451