Fix backquote on dotted pairs #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a couple extra cases to backquote's simplification step, which accounts for if the expression is an improper list or dotted pair.
|
It seems the build failed for it. It might be some bootstrapping issue or just the fix not being correct. It should be possible to test it in other implementation to see if it is related to bootstrap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a couple extra cases to backquote's simplification step, which accounts for if the expression is an improper list or dotted pair.
I'm not super happy with this implementation, since I'm not 100% sure these cases account for everything, but it seems to work correctly.