This repository has been archived by the owner on May 3, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 128
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Callback now acts like an on_ready event. Added on_error event. Remov…
…ed get_data. Improved docs, README.md and CONTRIBUTING.md
- Loading branch information
Showing
8 changed files
with
111 additions
and
126 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,17 @@ | ||
# Contributing | ||
|
||
When contributing to this repository, please first discuss the change you wish to make via issue, | ||
When contributing to this repository, please **first discuss the change you wish to make via issue**, | ||
email, or any other method with the owners of this repository before making a change. | ||
|
||
## Pull Request Process | ||
|
||
1. Ensure any install or build dependencies are removed before the end of the layer when doing a | ||
build. | ||
2. Update the documentation with the details of changes to the usage and behavior. | ||
3. Increase the version numbers in every file where the version number is present to the new version that this | ||
Pull Request would represent. The versioning scheme we use is [SemVer](http://semver.org/). | ||
4. You may merge the Pull Request in once you have the sign-off of two other developers, or if you | ||
do not have permission to do that, you may request the second reviewer to merge it for you. | ||
1. Install all the dependencies using `npm install` | ||
2. Make your changes and test them. Note that depending on your changes you may also have to modify existing tests or create new ones. | ||
3. **Run the tests** using `npm run test` | ||
4. **Build** the minified version using `npm run build` | ||
5. **Update the docs** (index.html) with the changes. If it is a new feature ensure to include it in the first example. | ||
6. **Increase the version numbers in every file** where the version number is present to the new version that this Pull Request would represent. The versioning scheme we use is [SemVer](http://semver.org/). | ||
|
||
## Optional | ||
|
||
Consider making your changes also in [jquery.instagramFeed](https://github.com/jsanahuja/jquery.instagramFeed). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.