Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro-pure.js.org #9424

Merged
merged 2 commits into from
Dec 7, 2024
Merged

astro-pure.js.org #9424

merged 2 commits into from
Dec 7, 2024

Conversation

cworld1
Copy link
Contributor

@cworld1 cworld1 commented Dec 3, 2024

The site content is:

  • A astro theme template showing for theme astro-theme-pure
  • With a bundled docs for theme usage and detailed project development descriptions

Note:

  • I cannot split out the template and docs, because I had to show usage and render them on docs page...
  • Also I found out that pure.js.org is a seven year old and poorly maintained library, is it possible to request this more concise subdomain? I think I might be able to ask the author for unification as much as possible, but before I do so, I need to make sure I actually follow the js-org rules and can use the domain name.

@cworld1 cworld1 changed the title astro-theme-pure.vercel.app astro-pure.js.org Dec 3, 2024
@indus
Copy link
Member

indus commented Dec 3, 2024

@cworld1 (blog-)themes are often not very related to JavaScript and we tend to not accept those for that reason. But of course old domains that were created before this stricter focus remain active.
So the best thing to do would be to talk to the owner of pure.js.org and possibly take over the subdomain. This might be the best solution on both sides.

@cworld1
Copy link
Contributor Author

cworld1 commented Dec 3, 2024

"we tend to not accept those for that reason" you mean I cannot use 'astro-pure.js.org' even...? I'm a little awkward

@indus
Copy link
Member

indus commented Dec 3, 2024

@MattIPv4 am I wrong about "themes"? I mean it has a bunch of JS/TS and maybe is not comparable with themes or ui-kits that are mostly CSS based..

@MattIPv4
Copy link
Member

MattIPv4 commented Dec 3, 2024

I'm not sure really, feels like a grey area. Using the rubric of is it something that JavaScript developers specifically would use over anyone else, I would think no, as it's something that anyone creating a website might use?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Dec 3, 2024
@cworld1
Copy link
Contributor Author

cworld1 commented Dec 4, 2024

Well, take it easy. I can pack all the Astro components and create a normal package, then publish it to npm. I mean, it is more like a complex library that has an out-of-the-box theme template, related documentation, and a UI components library.

I’m very sorry that I cannot publish it to npm right now. I'm in the process of upgrading the project to Astro v5, which has plenty of breaking changes that I need to address and debug.

@MattIPv4
Copy link
Member

MattIPv4 commented Dec 4, 2024

👍 I think having the components distributed as a package would make it much more apparent that it is more than just a theme.

@cworld1
Copy link
Contributor Author

cworld1 commented Dec 4, 2024

I'm having trouble upgrading to the latest version of Astro, which was released yesterday at around 16:00 UTC+8. I believe it will take about another day to complete the upgrade. I've created an issue detailing a bug in Astro v5 and am currently waiting for a solution or patch for the implementation issues, which seems more likely to be a problem.

In the meantime, can I use the domain astro-pure.js.org in advance? The numerous breaking changes upstream have been quite frustrating. If there are any updates, I would like to leave a comment on this PR. I appreciate your help!

@indus
Copy link
Member

indus commented Dec 4, 2024

@cworld1 I would want to wait for when the content is ready and not have any provisional subdomains.

@indus indus added the on hold label Dec 4, 2024
@cworld1
Copy link
Contributor Author

cworld1 commented Dec 6, 2024

OK! Published at: https://www.npmjs.com/package/astro-pure

Components can be used like import { Button, CardList } from 'astro-pure/user'. And related documents like https://astro-theme-pure.vercel.app/docs/integrations/components will update after finished all works of new release.

This should take some times, especially as there is are some very terrible problems on server mode for Vercel for latest upstream Astro v5 (Reported at withastro/astro#12609, withastro/astro#12663, withastro/adapters#471, waiting for reply and future patches on release)

@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester on hold labels Dec 7, 2024
@indus
Copy link
Member

indus commented Dec 7, 2024

Welcome http://astro-pure.js.org

@indus indus merged commit 81de616 into js-org:master Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants