see #199: add support for attr.name and attr.type #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbduncan
reviewed
Feb 20, 2018
| @@ -13,6 +13,9 @@ | |||
|
|
|||
| import com.google.common.graph.EndpointPair; | |||
| import com.google.common.graph.Network; | |||
| import edu.uci.ics.jung.io.graphml.AttributeType; | |||
|
|
|||
| import java.beans.XMLEncoder; | |||
There was a problem hiding this comment.
@ziodave It looks to me that java.beans.XMLEncoder is never used, so this import should be removed if possible.
|
|
||
| if (null != ds.attributeName) | ||
| bw.write(" attr.name=\"" + ds.attributeName.replace("\"", """) + "\""); | ||
| if (null != ds.attributeType) bw.write(" attr.type=\"" + ds.attributeType.getValue() + "\""); |
There was a problem hiding this comment.
It seems that these if statements are lacking braces. Please run mvn fmt:format to fix this and any other formatting errors I may have missed. :)
There was a problem hiding this comment.
Uhm, the formatter isn't adding the braces, I'll add them.
There was a problem hiding this comment.
Oops, very sorry, I thought it did! Thank your very much for adding them anyway. :)
|
I'll defer to @jrtom now for evaluating the meat of this PR and the corresponding issue. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add support for GraphML-Attributes in the GraphMLWriter.