Fix pages that are excluded from the sidebar having no sidebar

jpmorganchase · Aug 23, 2023 · 7013042 · 7013042 · vercel · Aug 23, 2023
1 parent 0ced179
commit 7013042
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/fast-bulldogs-grab.md b/.changeset/fast-bulldogs-grab.md
@@ -0,0 +1,5 @@
+---
+'@jpmorganchase/mosaic-plugins': patch
+---
+
+Fix pages that are excluded from the sidebar having no sidebar
diff --git a/packages/plugins/src/SidebarPlugin.ts b/packages/plugins/src/SidebarPlugin.ts
@@ -245,9 +245,9 @@ const SidebarPlugin: PluginType<SidebarPluginPage, SidebarPluginOptions, Sidebar
       await Promise.all(
         rootUserJourneys.map(async rootDir => {
           const sidebarFilePath = path.posix.join(String(rootDir), filename);
-          let pages = await createPageList(rootDir);
-          pages = pages.filter(page => removeExcludedPages(page));
-          const groupMap = createGroupMap(pages);
+          const pages = await createPageList(rootDir);
+          const includedPages = pages.filter(page => removeExcludedPages(page));
+          const groupMap = createGroupMap(includedPages);
 
           const sidebarData = linkGroupMap(groupMap, rootDir);
           if (sidebarData[0] === undefined) {