Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build issues #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,7 @@ dmypy.json
# Cython debug symbols
cython_debug/

.idea
.idea

# VS Code
.vscode/
52 changes: 52 additions & 0 deletions .volkbay/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Author: @volkbay[2023]
#
## Example Usage ##
##
## Build image with: `docker build -t eklt-vio .`
## Run container with: `docker run -it -v <host_dataset_dir>:<container_dataset_dir> eklt-vio`
## Load environment: `source ../devel/setup.bash`
## Evaluate with: `python3 x_evaluate/test/evaluate.py --configuration x_evaluate/test/evaluate.yaml ...
## --output_folder <container_dataset_dir>/<dataset>/output ...
## --dataset_dir <container_dataset_dir> --frontend XVIO --name "XVIO"`
##
##
FROM osrf/ros:noetic-desktop-full

RUN apt-get update
RUN DEBIAN_FRONTEND=noninteractive apt-get install -y \
git python3-vcstool python3-catkin-tools libtool nano \
python3-pip

# Install Eigen3 v3.4 (required by Haste Lib used in X Lib, this version cannot be found in apt repo for Ubuntu 20.04)
WORKDIR /home
RUN git clone https://gitlab.com/libeigen/eigen.git && \
mkdir -p /home/eigen/build
WORKDIR /home/eigen/build
RUN cmake ../ -DCMAKE_INSTALL_PREFIX=/usr/local && \
make install

# Init catkin environment
ENV WORKSPACE /eklt_vio_ws
RUN mkdir -p /${WORKSPACE}/src
WORKDIR ${WORKSPACE}
RUN catkin init &&\
catkin config --extend /opt/ros/noetic

# Clone dependencies and modify CMake configurations
WORKDIR ${WORKSPACE}/src

#TODO: @volkbay: Change volkbay to jpl-x if PR accepted
RUN git clone https://github.com/volkbay/x_evaluate.git && \
## Following `sed` is required to clone git repos by HTTPS ...
## without global git configurations.
sed -i '[email protected]:+https://github.com/+g' x_evaluate/dependencies.yaml && \
vcs-import < x_evaluate/dependencies.yaml

# Build Catkin packages
RUN catkin build -j${nproc} x_evaluate

RUN pip3 install -r x_evaluate/requirements.txt && \
pip3 install ./x_evaluate

# Run container
ENTRYPOINT [ "/bin/bash" ]
24 changes: 24 additions & 0 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,27 @@ repositories:
type: git
url: [email protected]:ethz-asl/gflags_catkin.git
version: master
catkin_simple:
type: git
url: [email protected]:catkin/catkin_simple
version: master
x_events:
type: git
url: [email protected]:volkbay/x_events #TODO: @volkbay: Change volkbay to jpl-x if PR accepted
version: events
glog_catkin:
type: git
url: [email protected]:ethz-asl/glog_catkin
version: master
easy_profiler_catkin:
type: git
url: [email protected]:florian-world/x_easy_profiler_catkin
version: master
ceres_catkin:
type: git
url: [email protected]:ethz-asl/ceres_catkin
version: master
eigen_catkin:
type: git
url: [email protected]:ethz-asl/eigen_catkin
version: master
5 changes: 4 additions & 1 deletion src/x_evaluate/plots.py
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,10 @@ def boxplot_compare(ax: plt.Axes, x_tick_labels, data, legend_labels, colors=Non
ax.set_xticks(np.arange(n_xlabel))
ax.set_xticklabels(x_tick_labels)
ax.set_xlim(-.6, n_xlabel-.4)
ax.xaxis.grid(b=None)
try: # @volkbay: Matplotlib > 3.5 has changed attribute 'b' to 'visible'
ax.xaxis.grid(b=None)
except ValueError:
ax.xaxis.grid(visible=None)
if legend:
# ax.legend(leg_handles, leg_labels, bbox_to_anchor=(
# 1.05, 1), loc=2, borderaxespad=0.)
Expand Down