generated from jphacks/JP_sample
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
フロントUIの改善 #41
Merged
Merged
フロントUIの改善 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Riku-0801
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとう!いくつか気になったところをコメントしてます!
- ログインボタン
- 矢印の向き逆じゃない?
- 左向きに矢印が向いてるのがちょっと違和感ある気がした。
- ログアウトならわかる
- 検索ボックス
- バツの主張が激しすぎるように思った
- 色がくろすぎ? 灰色にするとよい?
- とりあえず虫眼鏡マークよりも大きくて濃くて目立つのはどうかな?って思った
- リピートボタン
- 発想はいいと思ったんだけど、有効、無効のときの色が分かりづらいかも
- 黒と藍色は差が分かりづらい(灰色と藍色とかは?)
- あともうちょっと太くてもいいかも
- 発想はいいと思ったんだけど、有効、無効のときの色が分かりづらいかも
- ページネーション部分
- 仕方ないけど段階によって幅が変わるのはちょっと気になる
- トラックの手順4のときとか
- ホーム画面
- わかりやすくなってる気がする
- これ影で浮かせるんじゃなくて文字部分のバックグラウンドカラーを白にしたらどんな感じになるのか気になる
@Riku-0801 |
ゆってぃーのコメント
|
ループ停止 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#40 に紐づく改善を行いました。