Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "💄 Fix Safari status bar style" #791

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

pomeloy
Copy link
Contributor

@pomeloy pomeloy commented Jan 20, 2024

Reverts #789

The theme-color tag is supported by all Apple devices released since 2015 (iOS 15, available from 2021).

In addition, the meta tag apple-mobile-web-app-capable has no effect unless full-screen mode as described in apple-apple-mobile-web-app-capable is specified. A regular congo webpage should not run in full-screen mode.

Copy link

netlify bot commented Jan 20, 2024

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c5f342c
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/65ab7bc471d017000838588f
😎 Deploy Preview https://deploy-preview-791--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther
Copy link
Owner

Having looked into this more closely now, I tend to agree. I did test the PR that introduced this change yesterday and couldn't see any negative consequences but it seems pointless if theme-color is already covering this use case.

@jpanther jpanther merged commit 31fcdcf into jpanther:dev Jan 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants