[cdc-common] Address comment.

joyCurry30 · Dec 29, 2023 · 7aef3a6 · 7aef3a6
1 parent b67e03c
commit 7aef3a6
Showing 1 changed file with 5 additions and 13 deletions.
diff --git a/...c/main/java/com/ververica/cdc/runtime/serializer/schema/ColumnWithPositionSerializer.java b/...c/main/java/com/ververica/cdc/runtime/serializer/schema/ColumnWithPositionSerializer.java
@@ -44,7 +44,7 @@ public class ColumnWithPositionSerializer
     private final TypeSerializer<Column> addColumnSerializer =
             new NullableSerializerWrapper<>(ColumnSerializer.INSTANCE);
 
-    private final TypeSerializer<String> existedColumnSerializer = new StringSerializer();
+    private final TypeSerializer<String> existedColumnNameSerializer = StringSerializer.INSTANCE;
 
     private final EnumSerializer<AddColumnEvent.ColumnPosition> positionEnumSerializer =
             new EnumSerializer<>(AddColumnEvent.ColumnPosition.class);
@@ -65,7 +65,7 @@ public AddColumnEvent.ColumnWithPosition copy(AddColumnEvent.ColumnWithPosition
         return new AddColumnEvent.ColumnWithPosition(
                 addColumnSerializer.copy(from.getAddColumn()),
                 from.getPosition(),
-                existedColumnSerializer.copy(from.getExistedColumnName()));
+                existedColumnNameSerializer.copy(from.getExistedColumnName()));
     }
 
     @Override
@@ -84,23 +84,15 @@ public void serialize(AddColumnEvent.ColumnWithPosition record, DataOutputView t
             throws IOException {
         addColumnSerializer.serialize(record.getAddColumn(), target);
         positionEnumSerializer.serialize(record.getPosition(), target);
-        if (record.getExistedColumnName() == null) {
-            target.writeInt(0);
-        } else {
-            target.writeInt(1);
-            existedColumnSerializer.serialize(record.getExistedColumnName(), target);
-        }
+        existedColumnNameSerializer.serialize(record.getExistedColumnName(), target);
     }
 
     @Override
     public AddColumnEvent.ColumnWithPosition deserialize(DataInputView source) throws IOException {
         Column addColumn = addColumnSerializer.deserialize(source);
         AddColumnEvent.ColumnPosition position = positionEnumSerializer.deserialize(source);
-        if (source.readInt() == 1) {
-            return new AddColumnEvent.ColumnWithPosition(
-                    addColumn, position, existedColumnSerializer.deserialize(source));
-        }
-        return new AddColumnEvent.ColumnWithPosition(addColumn, position, null);
+        return new AddColumnEvent.ColumnWithPosition(
+                addColumn, position, existedColumnNameSerializer.deserialize(source));
     }
 
     @Override