-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added bilinear filtering for drawimage #72
base: master
Are you sure you want to change the base?
Conversation
Fixes bug when alpha from foreground image would overwrite alpha from background image
Use composite when drawing images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I approve.
… On Mon, Dec 13, 2021 at 1:27 PM Charles Robertson ***@***.***> wrote:
Sorry. What is bi-linear filtering?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLHMI33VHBL5FCMTX3EGC3UQXRCVANCNFSM4GJ7XPDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@enkimute Does this help to smooth drawImage() results of a clip. Will your fix, effectively create anti-aliasing? Thank you 🙏 |
Hi Charles,
This fix only affects how pixels are sampled from the source image. It will
not help you create anti-aliased clipping masks.
(the easiest approach to get that would be to render your image larger, and
then downsample)
Regards,
Steven.
…On Mon, Dec 13, 2021 at 3:14 PM Charles Robertson ***@***.***> wrote:
@enkimute <https://github.com/enkimute> Does this help to smooth
*drawImage()* results of a clip.
So for instance I have clipped an image, using an *arc()*, to create a
circular avatar.
But, it is aliased.
Will your fix, effectively create anti-aliasing?
Thank you 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLHMI3JAMI6I6O2O4LFX7TUQX5V3ANCNFSM4GJ7XPDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@enkimute Hi Steven. Thanks for your reply. My code is:
|
Types of changes
Checklist
Description