Support response schemas #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for destiny-data-explorer pending review.Visit the deploys page to approve it
|
joshhunt
reviewed
Feb 9, 2023
src/lib/apiSchemaUtils.ts
Outdated
| if (found && "$ref" in found) { | ||
| throw new Error("Referenced schema can not be a reference schema itself"); | ||
| } | ||
|
|
||
| return found; | ||
| return found as OpenAPIV3.SchemaObject; |
There was a problem hiding this comment.
I might find some time to check it out myself, but it would be great if we avoided the type assertion/cast.
I know the openapi types are very.... 'everything is a union of everything', but i would prefer this explicitly threw an exception if something isn't as expected, rather than propagate unexpectedly down.
ciaran
force-pushed
the
response-schemas
branch
from
1bf7a17
to
64bb235
Compare
ciaran
force-pushed
the
response-schemas
branch
from
64bb235
to
9a4c0d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to handle schema objects which are wrapped via a
ResponseObjectholding aMediaTypeObject.Before:
After:
