Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/external dependencies #353

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Feat/external dependencies #353

merged 2 commits into from
Dec 6, 2023

Conversation

josdejong
Copy link
Owner

@josdejong josdejong commented Dec 6, 2023

This will change the vanilla-jsoneditor npm package such that it does not embed dependencies but instead import them. So, if you use these dependencies (like Ajv, lodash-es, jsonrepair, etc) too in your project, they can be shared instead of being bundled twice.

BREAKING CHANGE:

When using `vanilla-jsoneditor` directly in the browser,
you now have to `import { JSONEditor } from 'vanilla-jsoneditor/standalone.js'`.
@josdejong josdejong merged commit 9c1ad15 into main Dec 6, 2023
4 checks passed
@josdejong josdejong deleted the feat/external-dependencies branch December 6, 2023 13:39
@josdejong
Copy link
Owner Author

published now in v0.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant