-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add indentation on wrapped lines #295
Conversation
Thanks @fauzi9331 , that looks promising! I expect to review your PR after the holiday period. |
@fauzi9331 I have tried out your PR and it works like a charm, really nice! It is really much nicer for the eye. I've also tried with large documents and I don't see any performance problems or things that break. Some thoughts:
|
@fauzi9331 did you see my comments of last week? |
Hi @josdejong sorry for not replying sooner. Thank you for following up. |
Sounds good 😎 |
Hi @josdejong sorry for taking a long time. I've been busy with work and studies lately Here's the update:
|
Thanks a lot @fauzi9331 , this looks very neat! The configurable indentation indeed works like a charm. I see there is a linting issue and a failing test due to an outdated snapshot, I'll fix that right away. |
Question: any reason why |
Hi @josdejong no reason for it. I just chose to start from 0 😆 |
Can you publish it as v1.0.0? That indicates that it is mature and feature complete rather than "your first commit". |
@josdejong I have bumped the version to 1.0.0. there's no change in the code. do you want me to make new PR to update the version here too? |
Thanks! I'll update all dependencies including |
resolves #228
Hi, in this PR, I've created a custom decoration to add 'padding-left' and 'text-indent' to each line so that the wrapped lines also have indentation.
I used '@replit/codemirror-indentation-markers' as a reference to build this decoration and even copied one of their utility functions, getVisibleLines.
I'm not sure if I put the file in the correct directory, nor am I sure what tests I should do to ensure that I don't break anything. If you can advice, that would be great