fix: onChange event not fired after calling editor.set(...) (see #…

…318)
josdejong · Nov 8, 2023 · afaca42 · afaca42
1 parent 2eec4e6
commit afaca42
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/lib/components/JSONEditor.svelte b/src/lib/components/JSONEditor.svelte
@@ -157,9 +157,10 @@
     // new editor id -> will re-create the editor
     instanceId = uniqueId()
 
-    content = newContent
+    await tick() // await re-render (creating the new editor)
 
-    await tick() // await rerender
+    // update content *after* re-render, so that the new editor will trigger an onChange event
+    content = newContent
   }
 
   export async function update(updatedContent: Content): Promise<void> {

diff --git a/tools/develop-vanilla.html b/tools/develop-vanilla.html
@@ -384,8 +384,7 @@
           updated: ':)'
         }
         const str = JSON.stringify(updatedJson, null, 2)
-        const index = str.lastIndexOf('}')
-        const invalidStr = str.slice(0, index) + ']' + str.slice(index + 1)
+        const invalidStr = str + '['
         testEditor.update({ text: invalidStr })
       }