Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unitless quantity conversion bug #3117

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Unitless quantity conversion bug #3117

merged 6 commits into from
Jan 10, 2024

Commits on Dec 23, 2023

  1. Add test for conversion to unitless quantity

    @costerwi
    costerwi committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    6daf13a View commit details
    Browse the repository at this point in the history

  2. Avoid access to missing array index

    @costerwi
    costerwi committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    f8537db View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Also check that other.units is not empty

    @costerwi
    costerwi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    a9f686b View commit details
    Browse the repository at this point in the history

  2. Add test for abs of dimensionless unit

    @costerwi
    costerwi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    a8017ef View commit details
    Browse the repository at this point in the history

  3. Fix: avoid access to missing units array index

    @costerwi
    costerwi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    cda62c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge branch 'develop' into unitless-quantity-conversion-bug

    @josdejong
    josdejong authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6607151 View commit details
    Browse the repository at this point in the history