Skip to content

Commit

Permalink
fix: todos
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgepiloto committed Sep 13, 2024
1 parent 0c87a09 commit e961e7a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ select = [
"I", # isort, see https://beta.ruff.rs/docs/rules/#isort-i
# "N", # pep8-naming, see https://beta.ruff.rs/docs/rules/#pep8-naming-n
"PTH", # flake9-use-pathlib, https://beta.ruff.rs/docs/rules/#flake8-use-pathlib-pth
# "TD", # flake8-todos, https://docs.astral.sh/ruff/rules/#flake8-todos-td
"TD", # flake8-todos, https://docs.astral.sh/ruff/rules/#flake8-todos-td
]
ignore = [
# pycodestyle
Expand Down
5 changes: 2 additions & 3 deletions src/lamberthub/universal_solvers/arora.py
Original file line number Diff line number Diff line change
Expand Up @@ -586,9 +586,8 @@ def _get_W2prime(k, W, W_prime, epsilon=2e-2):
W_2prime = _get_Ws2prime(k)

else:
# TODO: a minus sign before "m" is imposed in original report. However,
# if placed, it does not provide convergence. This needs further
# investigation
# TODO: a minus sign before "m" is imposed in original report
# https://github.com/jorgepiloto/lamberthub/issues/151

# W_2prime = (5 * W_prime * k + 3 * W) / -m
W_2prime = (5 * W_prime * k + 3 * W) / m
Expand Down
4 changes: 1 addition & 3 deletions src/lamberthub/universal_solvers/gooding.py
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,7 @@ def d8rt(x):
# GOTO 3
goto3 = True

# --- THE ITERATION METHOD STARTS NOW ---
# The iterative Halley method starts now
# TODO: THIS IS THE HALLEY METHOD
# --- THE ITERATION METHOD FOR HALLEY STARTS NOW ---

while True:
# 5: LINE OF STATEMENT
Expand Down
1 change: 0 additions & 1 deletion src/lamberthub/universal_solvers/izzo.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ def _tof_equation_y(x, y, T0, ll, M):

@jit
def _tof_equation_p(x, y, T, ll):
# TODO: What about derivatives when x approaches 1?
return (3 * T * x - 2 + 2 * ll**3 * x / y) / (1 - x**2)


Expand Down

0 comments on commit e961e7a

Please sign in to comment.