Fix Dajax object visibility issue #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a visibility issue which manifests itself if you have a minification
process which wraps all the files inside a closure (e.g. function(){}()). An
example of such process is using django-pipeline.
|
@jorgebastida Would appreciate if you can have a look. Thanks! |
|
I've released my fork on pypi: https://pypi.python.org/pypi/django-dajax-ng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Currently
Dajaxobject is not attach to thewindowobject. This means it won't be visible to other code (ReferenceError: Dajax is not defined) if you use a minification process which wraps all of the minified files inside a closure (function(){}())).Most of the minification libraries, including commonly used
django-pipelinedo that.Proposed solution
In my proposed solution, I've wrap
Dajaxobject into a closure and attach it to thewindowobject. I've also did some cleanup and changed the code to consistently use$everywhere instead of usingjQueryin some and$in other places.Attaching an object to
windowobject is a fairly common thing to do if the code, like this one, is not built as a jQuery plugin.