Skip to content

Commit

Permalink
test: do not check error messages meant for humans (ansible-collectio…
Browse files Browse the repository at this point in the history
…ns#540)

##### SUMMARY

Reduce tests flakiness, as human error messages may change over time.
  • Loading branch information
jooola authored Aug 1, 2024
1 parent ee09398 commit 4bfd063
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 14 deletions.
2 changes: 0 additions & 2 deletions tests/integration/targets/floating_ip/tasks/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "Floating IP deletion is protected"

- name: test update Floating IP delete protection
hetzner.hcloud.floating_ip:
Expand Down Expand Up @@ -462,7 +461,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "Floating IP deletion is protected"

- name: test update Floating IP delete protection
hetzner.hcloud.floating_ip:
Expand Down
1 change: 0 additions & 1 deletion tests/integration/targets/load_balancer/tasks/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "load balancer deletion is protected"

- name: Test update delete_protection
hetzner.hcloud.load_balancer:
Expand Down
1 change: 0 additions & 1 deletion tests/integration/targets/network/tasks/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "network is delete protected"

- name: Test update delete protection
hetzner.hcloud.network:
Expand Down
1 change: 0 additions & 1 deletion tests/integration/targets/primary_ip/tasks/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "Primary IP deletion is protected"

- name: Test update delete protection
hetzner.hcloud.primary_ip:
Expand Down
3 changes: 0 additions & 3 deletions tests/integration/targets/server/tasks/test_basic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "server deletion is protected"

- name: test rebuild server fails if it is protected
hetzner.hcloud.server:
Expand All @@ -330,7 +329,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "server rebuild is protected"

- name: test remove server protection
hetzner.hcloud.server:
Expand Down Expand Up @@ -588,7 +586,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "server deletion is protected"

- name: remove protection from server
hetzner.hcloud.server:
Expand Down
1 change: 0 additions & 1 deletion tests/integration/targets/server/tasks/test_firewalls.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
that:
- result is failed
- result.failure.code == "not_found"
- result.failure.message == "firewall not-existing was not found"

- name: setup create firewalls
hetzner.hcloud.firewall:
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/targets/server/tasks/test_validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
that:
- result is failed
- result.failure.code == "not_found"
- result.failure.message == "server_type not-existing-server-type was not found"

- name: test create server with not existing image
hetzner.hcloud.server:
Expand All @@ -50,4 +49,3 @@
that:
- result is failed
- result.failure.code == "not_found"
- result.failure.message == "Image my-not-existing-image-20.04 was not found"
1 change: 0 additions & 1 deletion tests/integration/targets/ssh_key/tasks/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@
that:
- result is failed
- result.failure.code == "uniqueness_error"
- result.failure.message == "SSH key with the same fingerprint already exists"

- name: test delete ssh key
hetzner.hcloud.ssh_key:
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/targets/volume/tasks/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "volume deletion is protected"

- name: test update Volume delete protection
hetzner.hcloud.volume:
Expand Down Expand Up @@ -256,7 +255,6 @@
that:
- result is failed
- result.failure.code == "protected"
- result.failure.message == "volume deletion is protected"

- name: test update Volume delete protection
hetzner.hcloud.volume:
Expand Down

0 comments on commit 4bfd063

Please sign in to comment.