Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't ignore composer.lock #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rodsouto
Copy link

@rodsouto rodsouto commented Feb 4, 2015

Ignoring the composer.lock file is considered a bad practice because it forces us to do a 'composer update' every time we add a new dependency instead of the proper 'composer install'

related: https://blog.engineyard.com/2014/composer-its-all-about-the-lock-file

Ignoring the composer.lock file is considered a bad practice because it forces us to do a 'composer update' every time we add a new dependency instead of the proper 'composer install'

related: https://blog.engineyard.com/2014/composer-its-all-about-the-lock-file
@blag001
Copy link
Contributor

blag001 commented May 7, 2015

I think keeping the .lock outside GIT (as the vendor/ folder) is the best way :
you clone the project without the content of vendor/ and you will never save it in git, so same thing for the .lock file.

@JnMik
Copy link

JnMik commented Mar 10, 2016

.lock file is important in the git repository, it is THE way to freeze all the dependencies you have for the current release, which have been tested and known as "bug free".

If I clone the project and run composer install based on the composer.json, I might as well pull newest tag of dependencies which break the current application code, and I won't know if the app owner is responsible or not.

So I'll say +1 to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants