Metal issues #8 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes @inhertiDoc from methods that were not inherited, and fixes a {String} type declaration to be lowercase.
This reverts commit dbaf7b8. That's necessary because this component's template may run via Java, which would cause errors when rendered due to attributes like `onclick` being set to strings (when rendered through javascript these are set as element properties, not attributes).
This can conflict with the soy file when using tools like browserify to build the code.
|
Closing as this is being deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecate#8
There is a bootstrap class of
modal-openthat disables scroll on the body and allows the modal to scroll when it extends past the body.Let me know if you have any questions. Thanks!