Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tls option to worker builder #74

Merged
merged 15 commits into from
Aug 18, 2024
Merged

Add tls option to worker builder #74

merged 15 commits into from
Aug 18, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented Jul 13, 2024 •
edited by jonhoo
Loading

This change is Reviewable

@rustworthy rustworthy marked this pull request as draft July 13, 2024 15:50
@codecov Codecov
Copy link

codecov bot commented Jul 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 67.3%. Comparing base (011b847) to head (af21d7d).
Report is 1 commits behind head on chore/tech-debt.

Files Patch % Lines
src/worker/builder.rs 36.8% 12 Missing ⚠️
src/tls/rustls.rs 0.0% 9 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
src/tls/rustls.rs 0.0% <0.0%> (ø)
src/worker/builder.rs 90.0% <36.8%> (-10.0%) ⬇️

@rustworthy rustworthy mentioned this pull request Jul 13, 2024
Merged
@rustworthy rustworthy requested a review from jonhoo August 14, 2024 12:47
@rustworthy
Copy link
Collaborator Author

peer reviews, self reviews, upward reviews, quarterly reviews, and yearly reviews ... and code reviews

btw that was a sick reprise with an item and a half

@rustworthy rustworthy marked this pull request as ready for review August 14, 2024 12:55
jonhoo
jonhoo requested changes Aug 18, 2024
View reviewed changes
src/tls/native_tls.rs Outdated Show resolved Hide resolved
src/tls/rustls.rs Outdated Show resolved Hide resolved
src/tls/rustls.rs Outdated Show resolved Hide resolved
src/worker/builder.rs Outdated Show resolved Hide resolved
rustworthy and others added 2 commits August 18, 2024 12:01
@rustworthy @jonhoo
Update src/tls/native_tls.rs
65c31e8 
Co-authored-by: Jon Gjengset <[email protected]>
@rustworthy @jonhoo
Update src/tls/rustls.rs
0826522 
Co-authored-by: Jon Gjengset <[email protected]>
@rustworthy rustworthy requested a review from jonhoo August 18, 2024 08:17
jonhoo
jonhoo approved these changes Aug 18, 2024
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's land it! 🎉

@jonhoo jonhoo merged commit b9290a8 into chore/tech-debt Aug 18, 2024
18 of 19 checks passed
@rustworthy rustworthy deleted the chore/ergonomic-tls branch September 19, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone