Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Worker::connect to use the password in the URL, as Client::connect does. #73

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

constlhq
Copy link
Contributor

@constlhq constlhq commented Jul 10, 2024

This change is Reviewable

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.3%. Comparing base (a4832db) to head (b9195dc).
Report is 5 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
src/worker/builder.rs 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@rustworthy rustworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch and the correct update, thank you!

This blunder has only been possible because I never added a test for the WorkerBuilder authenticated flow. I've just added #75 as a primer and as soon as a more ergonomic access to the tls feature will be enabled (which is now work-in-progress), this case will also be covered.

@rustworthy
Copy link
Collaborator

I guess we need to fmt the updated module

@rustworthy rustworthy requested a review from jonhoo July 13, 2024 17:07
@rustworthy
Copy link
Collaborator

Hey @constlhq! Thanks again for this fix!

Will you bandwidth to iterate over this once again?
The fmt job on the CI is failing, should be a quick fix.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonhoo jonhoo merged commit 5c0ff09 into jonhoo:main Jul 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants