Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use static dispatch in FaktoryCommand's issue #39

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Use static dispatch in FaktoryCommand's issue #39

merged 1 commit into from
Jan 3, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented Dec 25, 2023 •
edited by jonhoo
Loading

This change is Reviewable

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (481b152) 70.0% compared to head (829d069) 70.0%.

Additional details and impacted files
Files Coverage Δ
src/proto/single/cmd.rs 96.4% <80.0%> (ø)

@rustworthy
Copy link
Collaborator Author

rustworthy commented Dec 25, 2023 •
edited
Loading

static for libs and dynamic for bins :)

This part, though, is not user-facing and looks like staying with dynamic dispatch will also be just fine, but then unused type param can be removed

@rustworthy rustworthy mentioned this pull request Dec 25, 2023
Closed
@rustworthy rustworthy changed the title [WIP] Use static dispatch in FaktoryCommand's issue Use static dispatch in FaktoryCommand's issue Dec 25, 2023
jonhoo
jonhoo approved these changes Jan 3, 2024
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why I made this dyn in the first place, so happy to take this, thanks!

@jonhoo jonhoo merged commit a4e72fd into jonhoo:main Jan 3, 2024
15 of 16 checks passed
@jonhoo
Copy link
Owner

jonhoo commented Jan 3, 2024

I'll hold off on releasing this until #34 lands.

@jonhoo
Copy link
Owner

jonhoo commented Jan 3, 2024

Released in 0.12.2 🎉

@rustworthy rustworthy deleted the chore/clippy-warnings-fix branch January 4, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustworthy @jonhoo