Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clap from 3.2.25 to 4.4.12 and MSRV from 1.60.0 to 1.70.0 #34

Closed
wants to merge 10 commits into from
Closed

Bump clap from 3.2.25 to 4.4.12 and MSRV from 1.60.0 to 1.70.0 #34

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1d36319
Run 'cargo update' on sources
rustworthy Nov 30, 2023
6505ee5
Bump clap's major to 4
rustworthy Nov 30, 2023
13ff610
Adjust 'src/bin/loadtest.rs' to new clap API
rustworthy Nov 30, 2023
28d4d88
Use v3 of codecov-action
rustworthy Nov 30, 2023
721405f
Fix parsing number of jobs and threads
rustworthy Dec 1, 2023
6045614
Add 'openssl' as explicit dep, update test workflow for win
rustworthy Dec 11, 2023
8c63144
Set msrv to 1.70.0 (clippy@4 requirement)
rustworthy Dec 11, 2023
5094138
Merge branch 'main' into chore/update-deps
rustworthy Jan 3, 2024
76b1425
Rm duplicated openssl dep
rustworthy Jan 3, 2024
96475d5
Use strings[] for msrv matrix in 'check' workflow
rustworthy Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
# https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
strategy:
matrix:
msrv: [1.57.0]
msrv: [1.70.0]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this large MSRV bump? That's pretty significant (and recent). Is it required by anything we depend on?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is current clap's msrv.

As far as I understand they have been forced to bump it due to anstyle.

image

name: ubuntu / ${{ matrix.msrv }}
steps:
- uses: actions/checkout@v3
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ jobs:
matrix:
os: [macos-latest, windows-latest]
steps:
# https://github.com/sfackler/rust-openssl/issues/1542#issuecomment-1399358351
- name: Procure openssl on windows
if: runner.os == 'Windows'
run: |
echo "VCPKG_ROOT=$env:VCPKG_INSTALLATION_ROOT" | Out-File -FilePath $env:GITHUB_ENV -Append
vcpkg install openssl:x64-windows-static-md
- uses: actions/checkout@v3
with:
submodules: true
Expand Down Expand Up @@ -126,7 +132,7 @@ jobs:
env: # set this explicitly so integration tests will run
FAKTORY_URL: tcp://127.0.0.1:7419
- name: Upload to codecov.io
uses: codecov/codecov-action@v2
uses: codecov/codecov-action@v3
with:
fail_ci_if_error: true
services:
Expand Down
Loading