Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEst #378

Closed
wants to merge 262 commits into from
Closed

TEst #378

wants to merge 262 commits into from

Conversation

jonathangreen
Copy link
Owner

Description

Motivation and Context

How Has This Been Tested?

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

RishiDiwanTT and others added 30 commits September 5, 2023 19:41
…hePalaceProject#1347)

* Maintain type coercions during collections settings mutation

* Alembic migration script to coerce license goal settings to the right types

* Use pydantic for type coercion
Bumps [types-pillow](https://github.com/python/typeshed) from 10.0.0.2 to 10.0.0.3.
- [Commits](https://github.com/python/typeshed/commits)

---
updated-dependencies:
- dependency-name: types-pillow
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test_scripts tests for correctly configured variables as well by running a single script
* Fix language code validation, and add some tests for it.
- Fixed the type for default_reservation_period
- Fixed the primary key queries for the library integration configurations
- Additional logging on the migration
- Added a join condition so we are only updating library configurations that need to be updated
- Only write updated settings to the DB when there have been modifications to the settings
- Clean up tests

Co-authored-by: Jonathan Green <[email protected]>
* 🔥 Local LCP content
* Remove lcp-encrypt from base image
* Remove self_hosted property from license_pools
* Add migration
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5.
- [Release notes](https://github.com/docker/metadata-action/releases)
- [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md)
- [Commits](docker/metadata-action@v4...v5)

---
updated-dependencies:
- dependency-name: docker/metadata-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v4...v5)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* OPDS 1.2 and 2.0 refactor

With an acquisition page feed
This aims to remove all XML directives from within the feed and annotator workflows
And also to simplify the workflow making it more linear and less circular
Only a Serializer should write XML to the feed

Serializers are picked up the the basis of the Accept header sent to the endpoint.
Currently only the /feed, /group and /loans endpoints react to the Accept headers, the rest are still OPDS 1.2
We are not using the collection content mirroring functionality anywhere in our production CMs and the settings to support this add additional complexity to collection configuration screens.

This was done as part of the work for PP-95.
* Add some clarifying tests.

* Fix `previous_months` and add docstring.

* Improve and clarify tests and docstring.

* Remove redundant tests.
Bumps [pycryptodome](https://github.com/Legrandin/pycryptodome) from 3.18.0 to 3.19.0.
- [Release notes](https://github.com/Legrandin/pycryptodome/releases)
- [Changelog](https://github.com/Legrandin/pycryptodome/blob/master/Changelog.rst)
- [Commits](Legrandin/pycryptodome@v3.18.0...v3.19.0)

---
updated-dependencies:
- dependency-name: pycryptodome
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 152 lines in your changes are missing coverage. Please review.

Comparison is base (b384285) 89.90% compared to head (c53edc8) 90.05%.

Files Patch % Lines
api/controller/loan.py 63.82% 63 Missing and 26 partials ⚠️
api/controller/work.py 90.24% 6 Missing and 6 partials ⚠️
api/controller/circulation_manager.py 90.26% 6 Missing and 5 partials ⚠️
api/controller/opds_feed.py 96.31% 3 Missing and 3 partials ⚠️
api/admin/controller/collection_settings.py 92.64% 1 Missing and 4 partials ⚠️
api/admin/controller/quicksight.py 90.74% 4 Missing and 1 partial ⚠️
api/controller/annotation.py 93.44% 2 Missing and 2 partials ⚠️
api/controller/index.py 89.47% 2 Missing and 2 partials ⚠️
api/controller/analytics.py 86.36% 1 Missing and 2 partials ⚠️
api/controller/marc.py 96.70% 1 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   89.90%   90.05%   +0.15%     
==========================================
  Files         212      248      +36     
  Lines       28646    29176     +530     
  Branches     6538     6549      +11     
==========================================
+ Hits        25754    26275     +521     
- Misses       1886     1915      +29     
+ Partials     1006      986      -20     
Flag Coverage Δ
Api 76.07% <90.97%> (?)
Core 58.49% <19.51%> (?)
migration 26.69% <19.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants