Use flock to guard against concurrent cache access #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock the `local` dir with `flock -Fs` for shared read locks and `flock -Fx` when updating This prevents certain failure at concurrency >=5 and succedes past concurrency of 70 Change-Id: I5beda9168b13b0525dc108c2ca85f9d21e126780
|
I've had some trouble with the cache server seeming to corrupt already-cached repos on client fetch/update with 6 CI machines. I'll try this patch out. |
Did it help @jacobschloss ? |
|
It helped, decreased from near constant corruption to maybe once every few weeks (6 machines on either 10G or 25G LAN). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock the
localdir withflock -Fsfor shared read locks andflock -Fxwhen updatingThis prevents certain failure at concurrency >=5 and succedes past concurrency of 70
Change-Id: I5beda9168b13b0525dc108c2ca85f9d21e126780