Tune up the Samplers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
force-pushed
the
feature/correct-probabilistic-sampler-exception
branch
from
bd4149f to
3d30aa4
Compare
jonahgeorge
approved these changes
Aug 22, 2018
README.md
Outdated
| Install [Composer](https://getcomposer.org) in a common location or in your project. Then run the installer as follows: | ||
|
|
||
| ```bash | ||
| php composer.phar require jonahgeorge/jaeger-client-php |
There was a problem hiding this comment.
Really just the smallest nit: Can we get rid of the composer install instruction and do
composer require <>instead of the phar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutOfBoundsExceptiononProbabilisticSampler::__constructinstead of justException/cc @jonahgeorge