Add PHP 8.4 support

jonahgeorge · Dec 21, 2024 · dd15fbe · dd15fbe
1 parent 39e35bc
commit dd15fbe
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/src/Jaeger/Config.php b/src/Jaeger/Config.php
@@ -87,9 +87,9 @@ public function getLogger()
      */
     public function __construct(
         array $config,
-        string $serviceName = null,
-        LoggerInterface $logger = null,
-        CacheItemPoolInterface $cache = null
+        ?string $serviceName = null,
+        ?LoggerInterface $logger = null,
+        ?CacheItemPoolInterface $cache = null
     ) {
         $this->config = $config;
 

diff --git a/src/Jaeger/Reporter/LoggingReporter.php b/src/Jaeger/Reporter/LoggingReporter.php
@@ -21,7 +21,7 @@ class LoggingReporter implements ReporterInterface
      *
      * @param LoggerInterface|null $logger
      */
-    public function __construct(LoggerInterface $logger = null)
+    public function __construct(?LoggerInterface $logger = null)
     {
         $this->logger = $logger ?? new NullLogger();
     }

diff --git a/src/Jaeger/ScopeManager.php b/src/Jaeger/ScopeManager.php
@@ -38,7 +38,7 @@ public function getActive(): ?OTScope
      * Sets the scope as active.
      * @param OTScope|null $scope
      */
-    public function setActive(OTScope $scope = null)
+    public function setActive(?OTScope $scope = null)
     {
         $this->active = $scope;
     }

diff --git a/src/Jaeger/Sender/JaegerSender.php b/src/Jaeger/Sender/JaegerSender.php
@@ -66,8 +66,8 @@ class JaegerSender implements SenderInterface
      */
     public function __construct(
         AgentIf $agentClient,
-        LoggerInterface $logger = null,
-        SpanToJaegerMapper $mapper = null
+        ?LoggerInterface $logger = null,
+        ?SpanToJaegerMapper $mapper = null
     ) {
         $this->agentClient = $agentClient;
         $this->logger = $logger ?? new NullLogger();

diff --git a/src/Jaeger/Sender/UdpSender.php b/src/Jaeger/Sender/UdpSender.php
@@ -62,7 +62,7 @@ class UdpSender
     public function __construct(
         AgentClient $client,
         int $maxBufferLength,
-        LoggerInterface $logger = null
+        ?LoggerInterface $logger = null
     ) {
         $this->client = $client;
         $this->maxBufferLength = $maxBufferLength;

diff --git a/src/Jaeger/ThriftUdpTransport.php b/src/Jaeger/ThriftUdpTransport.php
@@ -36,7 +36,7 @@ class ThriftUdpTransport extends TTransport
      * @param int $port
      * @param LoggerInterface $logger
      */
-    public function __construct(string $host, int $port, LoggerInterface $logger = null, Config $config = null)
+    public function __construct(string $host, int $port, ?LoggerInterface $logger = null, ?Config $config = null)
     {
         $this->setLogger($logger);
 

diff --git a/src/Jaeger/Tracer.php b/src/Jaeger/Tracer.php
@@ -96,8 +96,8 @@ public function __construct(
         ReporterInterface $reporter,
         SamplerInterface $sampler,
         $oneSpanPerRpc = true,
-        LoggerInterface $logger = null,
-        ScopeManager $scopeManager = null,
+        ?LoggerInterface $logger = null,
+        ?ScopeManager $scopeManager = null,
         $traceIdHeader = TRACE_ID_HEADER,
         $baggageHeaderPrefix = BAGGAGE_HEADER_PREFIX,
         $debugIdHeader = DEBUG_ID_HEADER_KEY,