Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a note when freeze/unfreeze is disabled in Jar Details View #869

Conversation

nischal-shetty2
Copy link
Contributor

Fixes #856
displays the disabled buttons along with a note on why the freeze/unfreeze operations are currently disabled.

Screen.Recording.2024-11-05.at.10.15.01.PM.mov

@nischal-shetty2
Copy link
Contributor Author

hey @theborakompanioni i've made the changes, could you take a look at it!

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Nov 6, 2024

Hey @nischal-shetty2!

I think you can always show the message, regardless if a UTXO is selected. What do you think @editwentyone?

Also, there is some defects in dark mode:

@nischal-shetty2
Copy link
Contributor Author

I think you can always show the message, regardless if a UTXO is selected. What do you think @editwentyone?

I think showing the message regardless of UTXO selection makes a lot of sense and is more practical! @theborakompanioni @editwentyone

Also, there is some defects in dark mode:

on it!

@nischal-shetty2
Copy link
Contributor Author

Displays message even without selection @theborakompanioni :

Screenshot 2024-11-06 at 8 30 42 PM

Darkmode:
Screenshot 2024-11-06 at 8 30 28 PM

LightMode
Screenshot 2024-11-06 at 8 30 20 PM

@theborakompanioni theborakompanioni self-requested a review November 7, 2024 14:28
@theborakompanioni
Copy link
Collaborator

Displays message even without selection

@nischal-shetty2 Nice 💪
I made some small adaptions. If you are satisfied and think this okay, let's merge!

@nischal-shetty2
Copy link
Contributor Author

I made some small adaptions. If you are satisfied and think this okay, let's merge!

The addition of the dynamic message provides a clear distinction for the user. Looks great! If there are no other changes, I think we’re good to merge.

@theborakompanioni theborakompanioni merged commit 8683195 into joinmarket-webui:devel Nov 7, 2024
1 check passed
@nischal-shetty2 nischal-shetty2 deleted the feat/jar-details-disabled-info branch November 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message to Jar Details View if operations are disabled
2 participants