Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: remove twitter link from settings page #790

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

0xSaksham
Copy link
Contributor

@0xSaksham 0xSaksham commented Jul 2, 2024

Resolves #750

  • Removed Dead Twitter Link from Settings Page

@0xSaksham 0xSaksham linked an issue Jul 2, 2024 that may be closed by this pull request
@theborakompanioni
Copy link
Collaborator

Nice. Thanks @0xSaksham 🙏

Can you also remove the settings.jam_twitter from the language files?

@0xSaksham
Copy link
Contributor Author

Sure man.

@0xSaksham
Copy link
Contributor Author

Nice. Thanks @0xSaksham 🙏

Can you also remove the settings.jam_twitter from the language files?

Ready to Merge 👍

@theborakompanioni
Copy link
Collaborator

Nice. Thanks @0xSaksham 🙏
Can you also remove the settings.jam_twitter from the language files?

Ready to Merge 👍

Should it also be removed from the other language files?

@0xSaksham
Copy link
Contributor Author

I didn't know that. I'll do a full codebase search and remove it from everywhere.

@0xSaksham
Copy link
Contributor Author

Removed the Translation "jam_twitter" from files.

@0xSaksham
Copy link
Contributor Author

@theborakompanioni Should I Squash and Merge this into main branch?

@theborakompanioni theborakompanioni changed the title Unused Twitter Link Remove from Settings Page ui: remove twitter link from settings page Jul 4, 2024
@0xSaksham 0xSaksham merged commit 4a5bf20 into master Jul 6, 2024
3 checks passed
@0xSaksham 0xSaksham deleted the 750-fix-remove-twitter-link branch July 6, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: remove twitter link
2 participants