Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add dev setup information in contributing.md doc #725

Merged

Conversation

Dayvvo
Copy link
Contributor

@Dayvvo Dayvvo commented Mar 6, 2024

Added information about dev mode features namely:

  • Multiple Jam Instances and their use in simulating collaborative transactions locally
  • Block explorer and RPC terminal
  • Dev setup page for accessing the above-named features

Partially resolves #724

@theborakompanioni
Copy link
Collaborator

Hey @Dayvvo!

Thanks for the PR.
There is some code in BitcoinQR.tsx I do not quite understand, as it has nothing todo with the linked issue or the description of your PR. There should already be a share button, when the navigator.share method is available.. Would you be able to explain your reasoning behind the change?

@Dayvvo Dayvvo force-pushed the add-devsetup-info-to-docs branch from 3b82b14 to 296b451 Compare March 7, 2024 21:00
@Dayvvo
Copy link
Contributor Author

Dayvvo commented Mar 7, 2024

Hello @theborakompanioni . Thanks for pointing that out!

You're right. Those changes were not supposed to be in this branch. Initially I was trying to attempt another feature. Sharing the QR image of an address along with the address with the share button and then raise an issue and a PR about that, but then I found that to not be possible with the navigator.share() implementation in the code and decided not to attempt that anymore. I believed those changes to not be present in this branch.

I have removed them and pushed only the changes related to the issue in the comment. Do take a look again. Thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@theborakompanioni theborakompanioni merged commit a26aeb8 into joinmarket-webui:master Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Info about Dev setup feature in contributing.md and and within app
2 participants