Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade to react 18 #700

Merged
merged 26 commits into from
Dec 6, 2023
Merged

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Nov 27, 2023

Finally updates to react 18.
This is actually the third attempt to do so - but there were always to many PRs waiting, which would have introduced many merge conflicts. Now in calmer times, it was picked up again.

Run npm install after checkout.

This updates most dependencies to their most recent versions.
Some behaviour had to be adapted (e.g. "success" step after importing a wallet), but all-in-all, it would work exactly as before.

Also noteworthy:

  • had to insert a "success" step after wallet import flow as a workaround (navigate did not work anymore)
  • finally "typescript-only" - disallow new js components

📸

How to test

  • Checkout the branch
  • Run npm install
  • Run npm run dev:start
  • Verify everything is working as before (please test "create wallet", "import wallet", "sending", "fidelity bonds", etc.)

@theborakompanioni theborakompanioni added dependencies Pull requests that update a dependency file tech dept Removes some technical debt refactoring Code refactoring without functional changes labels Nov 27, 2023
@theborakompanioni theborakompanioni self-assigned this Nov 27, 2023
@theborakompanioni theborakompanioni force-pushed the upgrade-react-18 branch 3 times, most recently from aa49c45 to 3889c0f Compare November 30, 2023 22:09
@theborakompanioni theborakompanioni requested review from editwentyone and a team December 1, 2023 14:25
@theborakompanioni theborakompanioni marked this pull request as ready for review December 1, 2023 14:25
@theborakompanioni theborakompanioni merged commit d566936 into master Dec 6, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the upgrade-react-18 branch December 6, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactoring Code refactoring without functional changes tech dept Removes some technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants