Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: ability to reset fee values in dev mode #698

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Nov 26, 2023

Ability to reset fee values in dev mode.

Some fee properties (max_cj_fee_abs and max_cj_fee_rel) do not have default values if JM is installed from scratch.
You can now reset those fee values if you want to test what the UI looks like, when a user does not have these values configured.

Misc:

  • also added the "dev" badge to the test toggle on the scheduler page

How to test

  • Start the app in dev mode with npm run dev:start
  • Go to settings -> Click "Adjust fee limits"
  • Click the "Reset form values" button (notice how the form becomes invalid)
  • Click "Save" - form should not be able to be submitted
  • Toggle (disable) "Enable form validation"
  • Now click "Save" again - config will be updated
  • Visit "Send" or "Sweep" page and verify the alert message saying fee config values are missing

📸




(This message was there all along.. as dev you just never really saw it)

@theborakompanioni theborakompanioni added the devtools Improvements in tooling label Nov 26, 2023
@theborakompanioni theborakompanioni self-assigned this Nov 26, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review November 26, 2023 01:33
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as intended

@theborakompanioni theborakompanioni merged commit 3274a22 into master Nov 30, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the dev/dev-mode-reset-fee-config branch November 30, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools Improvements in tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants