Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use orderbook.json instead of parsing html table #687

Merged
merged 5 commits into from
Nov 2, 2023
Merged

fix: use orderbook.json instead of parsing html table #687

merged 5 commits into from
Nov 2, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Oct 26, 2023 •
edited
Loading

Closes #454.
Closes #561.

  • Fetches orderbook.json instead of parsing the html table to get data.
  • Uses normalized fidelity bond value
  • Removes column "Miner Fee Contribution"

📸 Before/After

@theborakompanioni theborakompanioni added UI/UX Issue related to cosmetics, design, or user experience tech dept Removes some technical debt labels Oct 26, 2023
@theborakompanioni theborakompanioni self-assigned this Oct 26, 2023
@theborakompanioni theborakompanioni mentioned this pull request Oct 26, 2023
Closed
@theborakompanioni theborakompanioni marked this pull request as ready for review October 26, 2023 22:25
editwentyone
editwentyone approved these changes Nov 2, 2023
View reviewed changes
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@theborakompanioni theborakompanioni merged commit df81804 into master Nov 2, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the refactor/orderbook-json branch November 2, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@editwentyone editwentyone editwentyone approved these changes

@httpiga httpiga Awaiting requested review from httpiga

Assignees

@theborakompanioni theborakompanioni

Labels
tech dept Removes some technical debt UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalise Bond values or color the non-zero values? Use orderbook.json instead of parsing html table
2 participants
@theborakompanioni @editwentyone