Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove create wallet button from settings page #680

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Oct 18, 2023

This is just a proposal, feel free to close it, if you think it is not a good idea.

I do not quite see the use of a "create wallet" button from the settings page.
A wallet can already be created from the main view when no wallet is active.
This PR will remove the button from the settings page.

What do you think?

📸 Before/After

@theborakompanioni theborakompanioni added concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience labels Oct 18, 2023
@theborakompanioni theborakompanioni self-assigned this Oct 18, 2023
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, just the right thing to do

@theborakompanioni theborakompanioni merged commit adfac29 into master Oct 18, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the chore/settings-rm-create branch October 18, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants