chore(import): display warning on large gaplimit values #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
the
UI/UX
theborakompanioni
force-pushed
the
chore/warn-on-large-gaplimit
branch
from
afd7990 to
85a3b51
Compare
|
ACK |
editwentyone
approved these changes
Sep 11, 2023
|
Will change wording from "an extreme decline of performance and responsiveness is to be expected" to something like "can lead to a decline of performance and responsiveness". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes should improve user experience and prevent some mistakes while importing wallets by adding visual feedback:
10_000_000- just to prevent errors during import (should be lower than the current blockheight anyway)10_000- rather high , but users should not be prevented from doing it, if they really want to250(arbitrarily chosen) will display a warning📸