Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fee-randomization): fix fee range in PaymentConfirmModal #655

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Sep 9, 2023

Resolves #654.

Adapts the texts and fee calculation for backends >=v0.9.10.

  • Adapt fee range in PaymentConfirmModal
  • Adapt description in Fee Settings

@theborakompanioni theborakompanioni added the bug Something isn't working label Sep 9, 2023
@theborakompanioni theborakompanioni self-assigned this Sep 9, 2023
@theborakompanioni theborakompanioni force-pushed the fix/upward-fee-randomization branch from 6988229 to 314eb03 Compare September 13, 2023 18:32
@theborakompanioni theborakompanioni force-pushed the fix/upward-fee-randomization branch from 314eb03 to fa24c33 Compare October 8, 2023 14:52
@theborakompanioni theborakompanioni marked this pull request as ready for review October 8, 2023 14:53
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@theborakompanioni theborakompanioni merged commit 31f54c8 into master Oct 12, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the fix/upward-fee-randomization branch October 12, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: transaction fees are only randomized upwards
2 participants