-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading an image with Styler #258
Open
MrWoWander
wants to merge
7
commits into
johnxnguyen:master
Choose a base branch
from
MrWoWander:styler
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1e19b5a
Downloading an Image into Styler
MrWoWander 140ec8f
Added macOS support
MrWoWander d7e62f9
fix support
MrWoWander a009e7e
fix lock
MrWoWander 3f852f3
asynchronous image loading
MrWoWander ad2b541
fix project path
MrWoWander 2745a14
add delegate update
MrWoWander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -187,8 +187,9 @@ open class DownStyler: Styler { | |
} | ||
|
||
open func style(image str: NSMutableAttributedString, title: String?, url: String?) { | ||
guard let url = url else { return } | ||
styleGenericLink(in: str, url: url) | ||
guard let url = url, | ||
let urlImg = URL(string: url) else { return } | ||
styleGenericImg(in: str, url: urlImg) | ||
} | ||
|
||
// MARK: - Common Styling | ||
|
@@ -218,6 +219,28 @@ open class DownStyler: Styler { | |
.link: url, | ||
.foregroundColor: colors.link]) | ||
} | ||
|
||
private func styleGenericImg(in str: NSMutableAttributedString, url: URL) { | ||
let semaphore = DispatchSemaphore(value: 0) | ||
URLSession.shared.dataTask(with: url) { data, _, _ in | ||
if let data = data { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A couple things:
|
||
let image1Attachment = NSTextAttachment() | ||
|
||
#if os(macOS) | ||
image1Attachment.image = NSImage(data: data) | ||
#else | ||
image1Attachment.image = UIImage(data: data) | ||
#endif | ||
let image1String = NSAttributedString(attachment: image1Attachment) | ||
|
||
str.setAttributedString(image1String) | ||
} | ||
|
||
semaphore.signal() | ||
}.resume() | ||
|
||
semaphore.wait() | ||
MrWoWander marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
// MARK: - Helpers | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: