-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getContainerSize #621
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for allotment-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for allotment-storybook failed.
|
I reverted the fix deps commit. |
Hi @livwvil. Thanks for taking the time to describe your use-case and put together a PR. I wonder if we can achieve this without any changes to the library? If we were to attach refs to any Note that this would rely on #582 being fixed first. |
The main problem is performance. I can get the size of the container by wrapping |
Take a look at the DockingManager story in |
Hi!
I am building a docking manager on top of this library and have run into a problem. I need to know the container size when Allotment onChange invoked.
Actually I need the width, height x and y of each panel inside the Allotment, but this is enough for me to find all the parameters myself.
If you want, I can add an advanced story next to VS Code with a docking manager.